Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate auth_jwt_claim_set directive #7238

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jan 29, 2025

Proposed changes

This change adds the CRD properties & validation that drive the setting of the auth_jwt_claim_set directive.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.78%. Comparing base (3f73934) to head (162f80e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7238      +/-   ##
==========================================
+ Coverage   52.72%   52.78%   +0.06%     
==========================================
  Files          89       89              
  Lines       20843    20879      +36     
==========================================
+ Hits        10989    11021      +32     
- Misses       9396     9398       +2     
- Partials      458      460       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

haywoodsh and others added 6 commits January 29, 2025 17:43
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
regex's might need more work
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@haywoodsh haywoodsh force-pushed the feat/rate-limit-auth-jwt-claim-set branch 2 times, most recently from 601923e to 9c3b159 Compare January 31, 2025 18:01
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@haywoodsh haywoodsh force-pushed the feat/rate-limit-auth-jwt-claim-set branch from 9c3b159 to 2a20bc5 Compare January 31, 2025 18:06
@pdabelf5 pdabelf5 marked this pull request as ready for review February 4, 2025 16:23
@pdabelf5 pdabelf5 requested a review from a team as a code owner February 4, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
Status: Todo ☑
Development

Successfully merging this pull request may close these issues.

3 participants