Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the go group across 1 directory with 5 updates #7265

Conversation

nginx-bot
Copy link
Contributor

Bumps the go group with 4 updates in the / directory: github.com/aws/aws-sdk-go-v2/config, github.com/aws/aws-sdk-go-v2/service/marketplacemetering, github.com/cert-manager/cert-manager and github.com/spiffe/go-spiffe/v2.

Updates github.com/aws/aws-sdk-go-v2/config from 1.29.2 to 1.29.4

Commits

Updates github.com/aws/aws-sdk-go-v2/service/marketplacemetering from 1.25.12 to 1.25.14

Commits

Updates github.com/cert-manager/cert-manager from 1.16.3 to 1.17.0

Release notes

Sourced from github.com/cert-manager/cert-manager's releases.

v1.17.0-beta.0

cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters.

v1.17.0 is a minor feature release including several improvements. Please help the project by testing this release!

cert-manager v1.17 includes:

  • A helpful compliance change to RSA signatures on certificates
  • An easier way to specify passwords for PKCS#12 and JKS keystores
  • Feature flag promotions and a deprecation
  • Dependency bumps and other smaller improvements

Major Themes

RSA Certificate Compliance

The United States Department of Defense published a memo in 2022 which introduced some requirements on the kinds of cryptography they require to be supported in software they use.

In effect, the memo requires that software be able to support larger RSA keys (3072-bit and 4096-bit) and hashing algorithms (SHA-384 at a minimum).

cert-manager supported large RSA keys long before the memo was published, but a quirk in implementation meant that cert-manager always used SHA256 when signing with RSA.

In v1.17.0, cert-manager will choose a hash algorithm based on the RSA key length: 3072-bit keys will use SHA-384, and 4096-bit keys will use SHA-512. This matches similar behavior already present for ECDSA signatures.

Our expectation is that this change will have minimal impact beyond a slight increase to security and better compliance; we're not aware of Kubernetes based environments which support RSA 2048 / SHA-256 but fail with RSA 4096 / SHA-512. However, if you're using larger RSA keys you should be aware of the change.

Easier Keystore Passwords for PKCS#12 and JKS

Specifying passwords on PKCS#12 and JKS keystores is supported in cert-manager for compatibility reasons with software which expects or requires passwords to be set; however, these passwords are not relevant to security and never have been in cert-manager.

The initial implementation of the keystores feature required these "passwords" to be stored in a Kubernetes secret, which would then be read by cert-manager when creating the keystore after a certificate was issued. This is cumbersome, and especially so when many passwords are set to default values such as changeit or password.

In cert-manager v1.17, it's now possible to set a keystore password using a literal string value inside the Certificate resource itself, making this process much easier with no change to security.

For example:

apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: my-cert-password
spec:
  secretName: my-cert-password
  issuerRef:
    name: my-issuer
    kind: ClusterIssuer
  keystores:
    jks:
      create: true
</tr></table> 

... (truncated)

Commits
  • 4562b9a Merge pull request #6657 from rquinio1A/feature/keystore-password-litteral
  • c6f3f0c Merge pull request #7527 from SgtCoDFish/upgrade-test-tweaks
  • 40cd2a0 Add support for setting literal keystore passwords in Certificates
  • 1747743 Merge pull request #7530 from SgtCoDFish/dns-test-integration
  • 8233733 split tests using 'live' DNS into separate package
  • 5e5ad2f Merge pull request #7529 from SgtCoDFish/bump-base
  • a522470 Merge pull request #7428 from jsoref/shorten-skipping-controller-messages
  • 2154402 bump base images to latest
  • 637eab3 Simplify skipping controller messages
  • c003da2 Merge pull request #7428 from jsoref/shorten-skipping-controller-messages
  • Additional commits viewable in compare view

Updates github.com/spiffe/go-spiffe/v2 from 2.4.0 to 2.5.0

Release notes

Sourced from github.com/spiffe/go-spiffe/v2's releases.

v2.5.0

Added

  • workloadapi.TargetFromAddress function to parse out a gRPC target from a SPIFFE_ENDPOINT_SOCKET compatible address (#321)

Changed

  • Minimum Go version is now go1.22.11, matching our downstream dependencies (#325)
Changelog

Sourced from github.com/spiffe/go-spiffe/v2's changelog.

[2.5.0] - 2025-01-31

Added

  • workloadapi.TargetFromAddress function to parse out a gRPC target from a SPIFFE_ENDPOINT_SOCKET compatible address (#321)

Changed

  • Minimum Go version is now go1.22.11, matching our downstream dependencies (#325)
Commits
  • dd15542 Changelog for 2.5.0 (#326)
  • f1afca7 Export function to get target from address (#321)
  • 078393f Bump google.golang.org/grpc from 1.67.1 to 1.70.0 in /v2 (#324)
  • 3a87d63 Upgrade to go1.22 (#325)
  • 896d311 Bump golang.org/x/net from 0.28.0 to 0.33.0 in /v2 (#322)
  • 49cafab Bump golang.org/x/crypto from 0.26.0 to 0.31.0 in /v2 (#323)
  • d5cb2fc Bump google.golang.org/protobuf from 1.34.2 to 1.36.1 in /v2 (#317)
  • b82bcea Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 in /v2 (#312)
  • 7c29672 Bump github.com/zeebo/errs from 1.3.0 to 1.4.0 in /v2 (#308)
  • 87cfecf doc: minor doc updates (#295)
  • See full diff in compare view

Updates k8s.io/utils from 0.0.0-20241104100929-3ea5e8cea738 to 0.0.0-20241210054802-24370beab758

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the go group with 4 updates in the / directory: [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2), [github.com/aws/aws-sdk-go-v2/service/marketplacemetering](https://github.com/aws/aws-sdk-go-v2), [github.com/cert-manager/cert-manager](https://github.com/cert-manager/cert-manager) and [github.com/spiffe/go-spiffe/v2](https://github.com/spiffe/go-spiffe).


Updates `github.com/aws/aws-sdk-go-v2/config` from 1.29.2 to 1.29.4
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@config/v1.29.2...config/v1.29.4)

Updates `github.com/aws/aws-sdk-go-v2/service/marketplacemetering` from 1.25.12 to 1.25.14
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@config/v1.25.12...service/waf/v1.25.14)

Updates `github.com/cert-manager/cert-manager` from 1.16.3 to 1.17.0
- [Release notes](https://github.com/cert-manager/cert-manager/releases)
- [Changelog](https://github.com/cert-manager/cert-manager/blob/master/RELEASE.md)
- [Commits](cert-manager/cert-manager@v1.16.3...v1.17.0)

Updates `github.com/spiffe/go-spiffe/v2` from 2.4.0 to 2.5.0
- [Release notes](https://github.com/spiffe/go-spiffe/releases)
- [Changelog](https://github.com/spiffe/go-spiffe/blob/main/CHANGELOG.md)
- [Commits](spiffe/go-spiffe@v2.4.0...v2.5.0)

Updates `k8s.io/utils` from 0.0.0-20241104100929-3ea5e8cea738 to 0.0.0-20241210054802-24370beab758
- [Commits](https://github.com/kubernetes/utils/commits)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
- dependency-name: github.com/aws/aws-sdk-go-v2/service/marketplacemetering
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
- dependency-name: github.com/cert-manager/cert-manager
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go
- dependency-name: github.com/spiffe/go-spiffe/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go
- dependency-name: k8s.io/utils
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@nginx-bot nginx-bot requested a review from a team as a code owner February 4, 2025 14:44
@nginx-bot nginx-bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-4.0@ff06d6a). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-4.0    #7265   +/-   ##
==============================================
  Coverage               ?   52.72%           
==============================================
  Files                  ?       89           
  Lines                  ?    20824           
  Branches               ?        0           
==============================================
  Hits                   ?    10979           
  Misses                 ?     9389           
  Partials               ?      456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) February 4, 2025 17:19
@pdabelf5 pdabelf5 merged commit 154e8c4 into release-4.0 Feb 4, 2025
21 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-4.0-769821947b1c774af4f82881e6bffec3fe37464c branch February 4, 2025 17:22
@pdabelf5 pdabelf5 removed the go Pull requests that update Go code label Feb 6, 2025
@pdabelf5 pdabelf5 changed the title [cherry-pick] chore(deps): bump the go group across 1 directory with 5 updates Bump the go group across 1 directory with 5 updates Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants