Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: integration tests for example modules #95

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

bavshin-f5
Copy link
Member

  • Test the whole process of building Rust code with --add-dynamic-module and the resulting modules with our Perl test framework
  • Fix doctests for nginx-sys and add to CI
  • Fix rustdoc warnings and add to CI
  • Fix all remaining clippy warnings

@bavshin-f5 bavshin-f5 requested a review from xeioex October 29, 2024 00:32
@bavshin-f5 bavshin-f5 force-pushed the ci-tests branch 2 times, most recently from 6f978e8 to 3cae15c Compare October 29, 2024 19:43
@bavshin-f5 bavshin-f5 force-pushed the ci-tests branch 2 times, most recently from b79cffd to 9048e95 Compare October 30, 2024 01:29
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking: nginx_sys -> nginx-sys?

Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

examples/t/upstream.t Show resolved Hide resolved
* clippy::legacy_numeric_constants in examples/httporigdst.rs
* clippy::single_match in examples/awssig.rs
There's a lot of duplication between these jobs, so running clippy
separately just wastes resources.
The example starts a multi-threaded tokio runtime in the master process.
@bavshin-f5 bavshin-f5 force-pushed the ci-tests branch 2 times, most recently from 8aae700 to 6f2d4eb Compare October 30, 2024 20:52
@bavshin-f5 bavshin-f5 merged commit 5e3d654 into nginx:master Oct 30, 2024
16 checks passed
@bavshin-f5 bavshin-f5 deleted the ci-tests branch October 30, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants