Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct default http_version from float to string #439

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

downingar
Copy link

Proposed changes

This is a simple fix that corrects the value of the default http_version to a string, which is what is required/expected by Nginx itself.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document.
  • I have added Molecule tests that prove my fix is effective or that my feature works.
  • I have checked that any relevant Molecule tests pass after adding my changes.
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md).

I'll admit to being lazy and not running any Molecule tests here, though one should probably be added to catch this. I have very little experience with Molecule, but I'm willing to add it if someone can give me a few hints on where to look and what to do.

@downingar downingar requested a review from alessfg as a code owner July 6, 2024 23:05
Copy link

github-actions bot commented Jul 6, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@downingar
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

@alessfg alessfg force-pushed the main branch 3 times, most recently from c32c384 to 7a27221 Compare November 30, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants