Issue 4837: chore: main_test.go unit-tests

[mrajagopal]

This is the first of potentially a few to get testability for main.go:

• Added unit-tests for the following functions:
• mustCreateConfigClient, mustValidateIngressClass, mustConfirmMinimumK8sVersionCriteria
• Some of the function names were ported from a PR based off an earlier revision of main branch

NOTE: At present there isn't any test for mustCreateDynamicClient as it doesn't seem testable

Proposed changes

The objective of this PR is to give test coverage for main.go as outlined in #4837.
This includes improving functions by:

returning the error instead of throwing a fatal error
Split functions to improve readability and testability

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[codecov]

Codecov Report

Attention: Patch coverage is 25.58140% with 32 lines in your changes missing coverage. Please review.

Project coverage is 53.09%. Comparing base (a41fc13) to head (f58aa90).
Report is 274 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/nginx-ingress/main.go	25.58%	32 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6314      +/-   ##
==========================================
+ Coverage   52.98%   53.09%   +0.11%     
==========================================
  Files          77       77              
  Lines       15900    15908       +8     
==========================================
+ Hits         8424     8447      +23     
+ Misses       7071     7048      -23     
- Partials      405      413       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jjngx]

The point of having functions with the prefix must is to communicate that those functions do not return errors (see Go std lib). They either call panic or os.Exit (log.Fatal). They prevent the NIC from starting in a state that would make it impossible to run.

There is no need to add additional error handling (or move call to os.Exit from inside the func) as there is no error returned. The function either validate or set some values or terminate the program.

[github-actions]

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.