Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/waf v5 docs #6694

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Docs/waf v5 docs #6694

wants to merge 21 commits into from

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Oct 21, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 21, 2024
@jjngx jjngx linked an issue Oct 21, 2024 that may be closed by this pull request
Update documentation for readOnlyRootFilesystem to include setting for WAF v5 #6626
Open
2 tasks
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6694/

@jjngx jjngx marked this pull request as ready for review October 22, 2024 08:20
@jjngx jjngx requested review from a team as code owners October 22, 2024 08:20
ADubhlaoich
ADubhlaoich approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor nitpick: Helm is the name of the software. We capitalise it each time unless we're talking about the actual binary command, helm.

site/content/installation/integrations/app-protect-waf-v5/installation.md Outdated Show resolved Hide resolved
site/content/installation/integrations/app-protect-waf-v5/installation.md Outdated Show resolved Hide resolved
site/content/installation/integrations/app-protect-waf-v5/installation.md Outdated Show resolved Hide resolved
pdabelf5
pdabelf5 reviewed Oct 24, 2024
View reviewed changes
site/content/configuration/security.md Outdated Show resolved Hide resolved
site/content/configuration/security.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel left review comments

@pdabelf5 pdabelf5 pdabelf5 left review comments

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Todo ☑
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation for readOnlyRootFilesystem to include setting for WAF v5
4 participants
@jjngx @ADubhlaoich @vepatel @pdabelf5