Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exporter library #11

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Add exporter library #11

merged 4 commits into from
Feb 16, 2024

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Feb 13, 2024 •
edited
Loading

Proposed changes

Problem:
We need a library to send product telemetry data as OTel to a remote endpoint.

Solution:

  • Add library to pkg/telemetry folder
  • Add .gitignore
  • Add Makefile with go-related targets.

Testing:

Closes #4

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING
    guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@pleshakov
Add exporter library
1e435e5 
Problem:
We need a library to send product telemetry data as OTel
to a remote endpoint.

Solution:
- Add library to pkg/telemetry folder
- Add .gitignore
- Add Makefile with go-related targets.

Testing:
- Unit test
- Manual testing with OTel collector
  https://opentelemetry.io/docs/collector/
@pleshakov pleshakov requested a review from a team as a code owner February 13, 2024 18:33
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements dependencies Pull requests that update a dependency file labels Feb 13, 2024
@pleshakov pleshakov mentioned this pull request Feb 13, 2024
Closed
@shaun-nx
Copy link

@pleshakov Looks great from what I can see.
I've pulled down the PR to test it against the telemetry job for NIC.
I'll let you know if we hit any problems. This will help with building out the examples for using the exporter for #5

jjngx
jjngx approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

sjberman
sjberman reviewed Feb 14, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
pkg/telemetry/error_handler.go Show resolved Hide resolved
pkg/telemetry/exporter_test.go Outdated Show resolved Hide resolved
kate-osborn
kate-osborn approved these changes Feb 15, 2024
View reviewed changes
Copy link

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shaun-nx
shaun-nx approved these changes Feb 16, 2024
View reviewed changes
Copy link

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pleshakov pleshakov merged commit cfbcaf8 into main Feb 16, 2024
6 checks passed
@pleshakov pleshakov deleted the feature/exporter branch February 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Exporter
6 participants
@pleshakov @shaun-nx @sjberman @ciarams87 @kate-osborn @jjngx