Update policy to traffic_policy on HTTP/TLS/TCP #890
Merged
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @TheConcierge and @rkolavo! I'm not sure how review requests do/should work here, or if either of you two are the right person to ping here, so just let me know—thanks! |
rkolavo
approved these changes
Aug 9, 2024
|
That's my bad. Good catch, Joel! |
TheConcierge
approved these changes
Aug 9, 2024
|
@TheConcierge Happy to help! Just noticed it as I was investigating the changelog ahead of working on the next newsletter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that after #862, some instances of example config files were changed from
policytotraffic_policy, but that hadn't reached the Traffic Policy-specific doc (example for HTTP) for each type of endpoint.This PR updates those three examples to update the naming. And fixes what I believe to be malformed indentation in the TCP example.