Skip to content

Commit

Permalink
fix bug in wl_queue_sizes
Browse files Browse the repository at this point in the history
  • Loading branch information
neilwalton committed Oct 28, 2024
1 parent ee45c38 commit 3eb9dfd
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 12 deletions.
3 changes: 1 addition & 2 deletions NHSRwaitinglist.Rproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ LaTeX: pdfLaTeX
StripTrailingWhitespace: Yes

BuildType: Package
PackageUseDevtools: Yes
PackageCleanBeforeInstall: No
PackageInstallArgs: --no-multiarch --with-keep.source
PackageCheckArgs: --as-cran
PackageRoxygenize: rd,collate,namespace,vignette
28 changes: 18 additions & 10 deletions R/wl_queue_size.R
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,23 @@ wl_queue_size <- function(waiting_list, start_date = NULL, end_date = NULL) {
queues[which(queues[, 1] %in% arrival_counts[, 1]), 2] <- arrival_counts[, 2]
queues$cummul_arrivals <- cumsum(queues[, 2])

departure_counts <- data.frame(
table(wl[which((start_date <= wl[, 2]) & (wl[, 2] <= end_date)), 2])
)
queues$departures <- rep(0, length(dates))
queues[which(queues[, 1] %in% departure_counts[, 1]), 4] <-
departure_counts[, 2]
queues$cummul_departures <- cumsum(queues[, 4])

queues$queue_size <- queues$cummul_arrivals - queues$cummul_departures
departures <- wl[which((start_date <= wl[, 2]) & (wl[, 2] <= end_date)), 2]
if(length(departures>0))
{
departure_counts <- data.frame(
table(wl[which((start_date <= wl[, 2]) & (wl[, 2] <= end_date)), 2])
)
queues$departures <- rep(0, length(dates))
queues[which(queues[, 1] %in% departure_counts[, 1]), 4] <-
departure_counts[, 2]
queues$cummul_departures <- cumsum(queues[, 4])

queues$queue_size <- queues$cummul_arrivals - queues$cummul_departures
} else {
queues$departures <- rep(0, length(dates))
queues$cummul_departures <- rep(0, length(dates))
queues$queue_size <- queues$cummul_arrivals
}

return(queues[, c(1, 6)])
}
}
2 changes: 2 additions & 0 deletions R/wl_simulator.R
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#' contains the referral dates
#'
#' @return dataframe. A df of simulated referrals and removals
#'
#' @import dplyr
#' @export
#'
#' @examples
Expand Down

0 comments on commit 3eb9dfd

Please sign in to comment.