-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lib and grpc time data types and conversions to enable future NI-DAQmx time support #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhindes
commented
Aug 21, 2023
zhindes
changed the title
Add AbsoluteTime data type to enable future NI-DAQmx time support
Add lib and grpc time data types and conversions to enable future NI-DAQmx time support
Aug 23, 2023
bkeryan
requested changes
Aug 24, 2023
bkeryan
reviewed
Aug 24, 2023
bkeryan
reviewed
Aug 24, 2023
bkeryan
reviewed
Aug 24, 2023
bkeryan
requested changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The important remaining issue is whether we should be converting to/from google.protobuf.timestamp_pb2.Timestamp
or google.protobuf.internal.well_known_types.Timestamp
.
These two new issues are not that important.
bkeryan
approved these changes
Aug 28, 2023
bkeryan
reviewed
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
It proposes one new data type:
nidaqmx._lib_time.AbsoluteTime
implements NI-BTF and conversion to and from Python'sdatetime
and NI'shightime
(see hightime) typesIt also provides conversions to and from gRPCs
Timestamp
type:nidaqmx._grpc_time.convert_time_to_timestamp
andnidaqmx._grpc_time.convert_timestamp_to_time
provide conversion to and fromhightime
type (in addition to maintainingdatetime
support)The proposal is that our user-facing API would all use
datetime
orhightime
interchangeably, and we would use these types under-the-hood to call into the C API or gRPC. One minor issue I see:hightime
as out-params. I think its probably fine to only returnhightime
since they inherit fromdatetime
, so it all works out.Why should this Pull Request be merged?
Trying to get some base functionality in place so future PRs can start adding time support.
What testing has been done?
New component tests.