test(e2e): remove unnecessary wait after cy.visit

This patch removes a now unnecessary wait after the `cy.visit()` call.
The upstream issue has been resolved in Cypress 12.

Ref: cypress-io/cypress#7306
Ref: cypress-io/cypress#7306 (comment)

cypress/e2e/smoke.cy.ts

@@ -13,7 +13,7 @@ describe('smoke tests', () => {
       password: faker.internet.password(),
     }
 
-    cy.visitAndCheck('/')
+    cy.visit('/')
     cy.findByRole('link', { name: /log in/i }).click()
     cy.findByRole('link', { name: /sign up/i }).click()
 
@@ -66,7 +66,7 @@ describe('smoke tests', () => {
       content: faker.lorem.paragraph(),
     }
     cy.login()
-    cy.visitAndCheck('/shows')
+    cy.visit('/shows')
 
     cy.findByRole('link', { name: /hermès/i })
       .should('have.length', 1)

cypress/support/commands.ts

@@ -37,18 +37,6 @@ declare global {
        *    cy.resetDatabase()
        */
       resetDatabase: typeof resetDatabase
-
-      /**
-       * Extends the standard visit command to wait for the page to load
-       *
-       * @returns {typeof visitAndCheck}
-       * @memberof Chainable
-       * @example
-       *    cy.visitAndCheck('/')
-       *  @example
-       *    cy.visitAndCheck('/', 500)
-       */
-      visitAndCheck: typeof visitAndCheck
     }
   }
 }
@@ -93,17 +81,6 @@ function resetDatabase() {
   cy.exec('pnpm prisma migrate reset --force')
 }
 
-// We're waiting a second because of this issue happen randomly
-// https://github.com/cypress-io/cypress/issues/7306
-// Also added custom types to avoid getting detached
-// https://github.com/cypress-io/cypress/issues/7306#issuecomment-1152752612
-// ===========================================================
-function visitAndCheck(url: string, waitTime: number = 1000) {
-  cy.visit(url)
-  cy.location('pathname').should('contain', url).wait(waitTime)
-}
-
 Cypress.Commands.add('login', login)
 Cypress.Commands.add('resetDatabase', resetDatabase)
 Cypress.Commands.add('cleanupUser', cleanupUser)
-Cypress.Commands.add('visitAndCheck', visitAndCheck)