-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build basic port with SvelteKit #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` $ npx sv create svelte-ui ``` ...was run to create this patch. Ref: https://tailwindcss.com/docs/plugins#forms Ref: https://svelte.dev/docs/kit/creating-a-project
I'll be trying Drizzle cause it looks interesting and it's one of the recommended tools when initializing a new SvelteKit project. For now, I'll just use my existing Prisma schema and use a database-first approach with `drizzle pull`. Ref: https://orm.drizzle.team/docs/overview Ref: https://orm.drizzle.team/docs/migrations
This patch adds a very basic collections list page that connects to our Postgres database and lists all of the collections available. The data is streamed from the server [[1]] via a server-only load function [[2]]. I use Drizzle [[3]] as the ORM of choice. It is more performant than Prisma and more flexible [[4]]. I introspect an existing Postgres database that contains all of the data and schemas currently in production (this database state was seeded with Prisma from the code in `remix-ui`) [[5]]. [1]: https://svelte.dev/docs/kit/load#Streaming-with-promises [2]: https://svelte.dev/docs/kit/load#Page-data [3]: https://orm.drizzle.team/ [4]: https://orm.drizzle.team/docs/overview [5]: https://orm.drizzle.team/docs/get-started/postgresql-existing#step-4---introspect-your-database
This patch adjusts the Prettier configuration to align with the existing opinionated configuration in `remix-ui`. Note that single quotes are disabled due to their unavailability in HTML markup. A few opinionated changes have been made, but I defer mostly to the default options in Prettier. Ref: sveltejs/language-tools#2098 Ref: https://prettier.io/docs/en/option-philosophy
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dolce
|
Project |
dolce
|
Branch Review |
nicholas/svelte
|
Run status |
|
Run duration | 00m 17s |
Commit |
|
Committer | Nicholas Chiang |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
1
|
View all changes introduced in this branch ↗︎ |
4c4cd88
to
21334e6
Compare
This patch uses the Drizzle select API instead of the query API to reduce overhead. We only select the first look for each collection and use a single query with two LEFT JOINs to accomplish a nearly identical UX that is 10x faster.
21334e6
to
067449b
Compare
31cc104
to
7e330fc
Compare
7e330fc
to
7195f7d
Compare
🎉 This PR is included in version 1.69.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.