-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(show): use show description as meta description #75
base: main
Are you sure you want to change the base?
Conversation
NC-666 Decide whether to use the show description or Vogue meta tag
Vogue's meta description for their show reviews looks like:
…which essentially seems to be redundant with the Rotten Tomatoes, on the other hand, uses the actual show description. Ex: Oppenheimer's description tag:
…I should decide which site I want to follow. Whatever looks best in Google search results will probably be what I land on. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #583 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
7e2dc15
to
fd45dfb
Compare
fd45dfb
to
457fb9e
Compare
0482920
to
e5dc557
Compare
e5dc557
to
441af50
Compare
441af50
to
0076ab0
Compare
This patch updates the show page description to use the show description if it exists, and revert back to the Vogue inspired description if it does not. This patch also adds some XSS support that may be somewhat premature, but was easy enough to add that it felt it wouldn't hurt. Closes: NC-666
0076ab0
to
02714c7
Compare
53eed68
to
2061c1e
Compare
2bee409
to
113e7f6
Compare
This patch updates the show page description to use the show description if it exists, and revert back to the Vogue inspired description if it does not.
This patch also adds some XSS support that may be somewhat premature, but was easy enough to add that it felt it wouldn't hurt.
Closes: NC-666