Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(show): use show description as meta description #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicholaschiang
Copy link
Owner

This patch updates the show page description to use the show description if it exists, and revert back to the Vogue inspired description if it does not.

This patch also adds some XSS support that may be somewhat premature, but was easy enough to add that it felt it wouldn't hurt.

Closes: NC-666

@linear
Copy link

linear bot commented Aug 6, 2023

NC-666 Decide whether to use the show description or Vogue meta tag

Vogue's meta description for their show reviews looks like:

032c Spring 2024 Menswear collection, runway looks, beauty, models, and reviews.

…which essentially seems to be redundant with the keywords meta tag. But it might be good for SEO. They are the G.O.A.T. after all.

image.png

Rotten Tomatoes, on the other hand, uses the actual show description. Ex: Oppenheimer's description tag:

During World War II, Lt. Gen. Leslie Groves Jr. appoints physicist J. Robert Oppenheimer to work on the top-secret Manhattan Project. Oppenheimer and a team of scientists spend years developing and designing the atomic bomb. Their work comes to fruition on July 16, 1945, as they witness the world's first nuclear explosion, forever changing the course of history.

…I should decide which site I want to follow. Whatever looks best in Google search results will probably be what I land on.

image.png

@vercel
Copy link

vercel bot commented Aug 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dolce ❌ Failed (Inspect) Sep 30, 2023 8:32pm
site ❌ Failed (Inspect) Sep 30, 2023 8:32pm

@cypress
Copy link

cypress bot commented Aug 6, 2023

Passing run #583 ↗︎

0 1 0 0 Flakiness 0

Details:

feat(show): use show description as meta description
Project: dolce Commit: 02714c747e
Status: Passed Duration: 00:51 💡
Started: Aug 19, 2023 9:27 PM Ended: Aug 19, 2023 9:28 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

This patch updates the show page description to use the show description
if it exists, and revert back to the Vogue inspired description if it
does not.

This patch also adds some XSS support that may be somewhat premature,
but was easy enough to add that it felt it wouldn't hurt.

Closes: NC-666
@nicholaschiang nicholaschiang force-pushed the main branch 3 times, most recently from 2bee409 to 113e7f6 Compare November 23, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant