Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkstyle fixes #20

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Checkstyle fixes #20

merged 3 commits into from
Nov 27, 2024

Conversation

nl2878
Copy link
Collaborator

@nl2878 nl2878 commented Nov 24, 2024 •
edited
Loading

  • mvn checkstyle:check runs clean.
  • Add javadoc comments for the new functions.
  • Fix some issues raise by the PMD static bug analyzer (pmd check -d src -R rulesets/java/quickstart.xml -f text).

nick-ching23
nick-ching23 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Owner

@nick-ching23 nick-ching23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@nick-ching23 nick-ching23 merged commit fa2f90a into main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-ching23 nick-ching23 nick-ching23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nl2878 @nick-ching23 @naren-loganathan