Better input behavior #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added input attributes to control autocorrect and other keyboard behavior that makes typing hosts hard * Port placeholder hints default port that it will fall back to
digitarald
pushed a commit
to digitarald/fxos-irc
that referenced
this pull request
Oct 4, 2013
|
Dude, @digitarald , 2 pull requests? You're a rockstar! Thanks so much! Let me take a look at the code real quick. |
| @@ -56,6 +56,15 @@ document.addEventListener("DOMContentLoaded", function () { | |||
| $advanced.style.display = "block"; | |||
| } | |||
| } | |||
| $("secure").onchange = function () { | |||
| var port = $("port"); | |||
| if (port.value) { | |||
There was a problem hiding this comment.
Instead of a true branch with an early return, can you just use if (!port.value) and put everything in that?
|
Also, please add your name and email to the License file |
* Added input attributes to control autocorrect and other keyboard behavior that makes typing hosts hard * Port placeholder hints default port that it will fall back to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nickdesaulniers r?