Allow configuration of nginx_ssl_directory #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. I am currently in the process of rewriting both this role and my let's encrypt role. A configurable SSL location and multiple certificates (at the LE level) are on the list. Going to keep this PR open as a reminder until they are both ready. |
|
Cool (I just submitted a small PR to your LE role also). Both these Ansible roles have already saved me time, so I look forward to the improved versions! |
Instead of hardcoding it to /etc/nginx/ssl
It doesn't make sense to have an upstream followed by =404. The @upstream parameter must be the last parameter. http://nginx.org/en/docs/http/ngx_http_core_module.html#try_files
When set to the name of an upstream, the direct_proxy variable causes
ALL requests to be proxied (so there is no try_file directive).
This is useful, for example, when proxying to a web server which handles
all static content or when the nginx reverse-proxy doesn't have access
to the origin server's root directory.
Example:
direct_proxy: apache
upstreams:
- name: apache
servers: ['apache_upstream_server']
For each entry in nginx_sites, create a file at /etc/nginx/conf.d/common_ssl_site.domains[0].conf containing its SSL configs, and include that in its main configuration files. This should fix upstream Issue #15. Also create /etc/nginx.conf.d/common_ssl_default.conf with the default SSL settings. This is convenient for other vhosts -- including those not managed by this role -- to be able to import.
I forgot everything in conf.d is included by the default nginx.conf file. Better to keep our configurations separate.
I forgot the /etc/nginx/conf.d/ dir is included by the main nginx.conf file. Store configuration snippets in our own directory (/etc/nginx/ansible-nginx-conf.d) instead.
For each entry in nginx_sites, create a file at /etc/nginx/conf.d/common_ssl_site.domains[0].conf containing its SSL configs, and include that in its main configuration files. This should fix upstream Issue #15. Also create /etc/nginx.conf.d/common_ssl_default.conf with the default SSL settings. This is convenient for other vhosts -- including those not managed by this role -- to be able to import.
nginx_main_directives works the same as nginx_http_directives but is outside of http block.
n00b42
pushed a commit
to n00b42/ansible-nginx
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my use case it will likely be convenient to be able to configure the directory where the SSL certificate/key is located (instead of hardcoding it to /etc/nginx/ssl). I have only very quickly tested this patch.