Skip to content

Commit

Permalink
Go back to using ld for libmsgpack-c
Browse files Browse the repository at this point in the history
Also shorten GHA job names
  • Loading branch information
nicolasff committed Nov 4, 2023
1 parent 9630672 commit 55c05ec
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on: [workflow_dispatch]

jobs:

build-and-test-linux:
validation-linux:
strategy:
fail-fast: false # don't cancel other jobs in the matrix if one fails
matrix:
Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:



build-and-test-macos:
validation-macos:
if: false # FIXME: restore before merging to master
strategy:
fail-fast: false
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ ifeq ($(strip $(MSGPACKC_LD)),0)
LDFLAGS += -lmsgpackc
else
# check for MessagePack-C (note the dash)
MSGPACK_C_LIB=$(shell ls /usr/lib/libmsgpack-c.so 2>/dev/null)
ifneq ($(strip $(MSGPACK_C_LIB)),)
MSGPACK_C_LD=$(shell ld -lmsgpack-c >/dev/null 2>/dev/null; echo $$?)
ifeq ($(strip $(MSGPACK_C_LD)),0)
FORMAT_OBJS += src/formats/msgpack.o
CFLAGS += -DMSGPACK=1
LDFLAGS += -lmsgpack-c
endif # MSGPACK_C_LIB
endif # MSGPACK_C_LD
endif # MSGPACKC_LD
endif # MSGPACK_OSX_LIB
endif # MSGPACKC_LIB
Expand Down

0 comments on commit 55c05ec

Please sign in to comment.