Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SepReader: Optimize MoveNextAsync #245

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Conversation

nietras
Copy link
Owner

@nietras nietras commented Jan 28, 2025

Update row benchmarks.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.63%. Comparing base (2a71b43) to head (6e16ac6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Sep/SepReader.IO.Async.cs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   99.66%   99.63%   -0.03%     
==========================================
  Files          54       54              
  Lines        4119     4120       +1     
  Branches      464      465       +1     
==========================================
  Hits         4105     4105              
- Misses         11       12       +1     
  Partials        3        3              
Flag Coverage Δ
Debug 99.41% <83.33%> (-0.05%) ⬇️
Release 99.82% <100.00%> (ø)
macos-latest 93.10% <91.66%> (-0.03%) ⬇️
ubuntu-latest 99.58% <91.66%> (-0.03%) ⬇️
windows-latest 99.58% <91.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nietras nietras merged commit 4dc2039 into main Jan 28, 2025
33 of 34 checks passed
@nietras nietras deleted the sepreader-optimize-movenextasync branch January 28, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant