Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename organization #903

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Rename organization #903

merged 2 commits into from
Dec 4, 2024

Conversation

nightscape
Copy link
Owner

@nightscape nightscape commented Dec 4, 2024

PR Type

Enhancement, Documentation


Description

  • Renamed the organization and package from com.crealytics to dev.mauch across all source, test, and configuration files.
  • Added a new utility file ExcelSparkInternal.scala for proxying Spark's InputFileBlockHolder.
  • Updated the README and GitHub issue templates to reflect the new package name and provide updated usage examples.
  • Upgraded the Mill build tool version from 0.12.1 to 0.12.3.
  • Adjusted Maven coordinates, build configuration, and DataSourceRegister entries to align with the new organization name.
  • Updated test imports and tags to use the new package name.

Changes walkthrough 📝

Relevant files
Enhancement
2 files
ExcelSparkInternal.scala
Add utility for Spark InputFileBlockHolder proxying           

src/main/2.4/scala/dev/mauch/spark/ExcelSparkInternal.scala

  • Added a new file ExcelSparkInternal.scala under the dev.mauch.spark
    package.
  • Introduced a utility object ExcelSparkInternal to proxy Spark's
    InputFileBlockHolder functionality.
  • +25/-1   
    package.scala
    Update package and format references in package object     

    src/main/scala/dev/mauch/spark/excel/package.scala

  • Updated package name from com.crealytics.spark to dev.mauch.spark.
  • Modified .format references to align with the new package name.
  • +3/-3     
    Documentation
    2 files
    generic.yml
    Update package references in GitHub issue template             

    .github/ISSUE_TEMPLATE/generic.yml

  • Updated example commands to use the new package name dev.mauch.
  • Adjusted format references in the issue template.
  • +2/-2     
    README.md
    Update README with new package name and examples                 

    README.md

  • Updated all references from com.crealytics to dev.mauch.
  • Adjusted Maven coordinates and example commands to reflect the new
    package name.
  • +12/-12 
    Configuration changes
    2 files
    build.sc
    Update build configuration with new organization name       

    build.sc

  • Changed the organization name in the build configuration from
    com.crealytics to dev.mauch.
  • +1/-1     
    org.apache.spark.sql.sources.DataSourceRegister
    Update DataSourceRegister with new package name                   

    src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister

  • Updated the data source register entry to reflect the new package name
    dev.mauch.
  • +1/-1     
    Dependencies
    1 files
    .mill-version
    Upgrade Mill build tool version                                                   

    .mill-version

    • Upgraded Mill version from 0.12.1 to 0.12.3.
    +1/-1     
    Tests
    2 files
    EncryptedReadSuite.scala
    Update test suite imports to new package name                       

    src/test/scala/dev/mauch/spark/excel/EncryptedReadSuite.scala

    • Updated package imports from com.crealytics to dev.mauch.
    +2/-2     
    package.scala
    Update test tags to new package name                                         

    src/test/scala/dev/mauch/tags/package.scala

    • Updated the WIP tag to reflect the new package name dev.mauch.
    +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    github-actions bot commented Dec 4, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Package Mismatch
    The package declaration in the new utility file does not match the expected new organization name. It should be updated to reflect the new organization structure.

    Copy link

    github-actions bot commented Dec 4, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nightscape nightscape force-pushed the rename-organization branch 2 times, most recently from e084015 to ff4f6bb Compare December 4, 2024 15:18
    @nightscape nightscape merged commit 09ae1ae into main Dec 4, 2024
    42 of 80 checks passed
    @nightscape nightscape deleted the rename-organization branch December 4, 2024 15:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant