1st fix pass

packages/cli/create-strapi-app/index.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+
 'use strict';
 
 require('./create-strapi-app');

packages/cli/create-strapi-starter/index.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+
 'use strict';
 
 require('./create-strapi-starter');

packages/cli/create-strapi-starter/utils/child-process.js

@@ -27,12 +27,11 @@ function runApp(rootPath, { useYarn } = {}) {
       stdio: 'inherit',
       cwd: rootPath,
     });
-  } else {
-    return execa('npm', ['run', 'develop'], {
-      stdio: 'inherit',
-      cwd: rootPath,
-    });
   }
+  return execa('npm', ['run', 'develop'], {
+    stdio: 'inherit',
+    cwd: rootPath,
+  });
 }
 
 async function initGit(rootPath) {

packages/cli/create-strapi-starter/utils/stop-process.js

@@ -1,4 +1,5 @@
 'use strict';
+
 const logger = require('./logger');
 
 module.exports = function stopProcess(message) {

packages/core/admin/ee/server/controllers/role.js

@@ -6,7 +6,7 @@ const {
   validateRoleDeleteInput,
   validateRolesDeleteInput,
 } = require('../validation/role');
-const { getService } = require('../../../server//utils');
+const { getService } = require('../../../server/utils');
 const { validatedUpdatePermissionsInput } = require('../validation/permission');
 const { SUPER_ADMIN_CODE } = require('../../../server/services/constants');
 

packages/core/admin/server/domain/action/__tests__/action-domain.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const domain = require('../');
+const domain = require('..');
 
 describe('Action Domain', () => {
   describe('appliesToProperty', () => {

packages/core/admin/server/domain/action/__tests__/action-provider.test.js

@@ -2,7 +2,7 @@
 
 const { omit } = require('lodash/fp');
 const createActionProvider = require('../provider');
-const domain = require('../');
+const domain = require('..');
 
 const providerMethods = [
   'register',

packages/core/admin/server/domain/condition/__tests__/condition-domain.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const domain = require('../');
+const domain = require('..');
 
 describe('Condition Domain', () => {
   describe('assignConditionId', () => {

packages/core/admin/server/domain/condition/__tests__/condition-provider.test.js

@@ -2,7 +2,7 @@
 
 const { omit } = require('lodash/fp');
 const createConditionProvider = require('../provider');
-const domain = require('../');
+const domain = require('..');
 
 const providerMethods = [
   'register',

packages/core/admin/server/domain/condition/provider.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const { providerFactory } = require('@strapi/utils');
-const domain = require('./');
+const domain = require('.');
 
 /**
  * @typedef ConditionProviderOverride

packages/core/admin/server/domain/permission/__tests__/permission-domain.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const domain = require('../');
+const domain = require('..');
 
 describe('Permission Domain', () => {
   describe('addCondition', () => {

packages/core/admin/server/routes/serve-admin-panel.js

@@ -23,7 +23,7 @@ const registerAdminPanelRoute = ({ strapi }) => {
     }
 
     ctx.type = 'html';
-    ctx.body = fse.createReadStream(join(buildDir + '/index.html'));
+    ctx.body = fse.createReadStream(join(`${buildDir}/index.html`));
   };
 
   strapi.server.routes([

packages/core/admin/server/services/role.js

@@ -109,7 +109,7 @@ const find = (params = {}, populate) => {
  */
 const findAllWithUsersCount = async populate => {
   const roles = await strapi.query('admin::role').findMany({ populate });
-  for (let role of roles) {
+  for (const role of roles) {
     role.usersCount = await getUsersCount(role.id);
   }
 
@@ -171,7 +171,7 @@ const checkRolesIdForDeletion = async (ids = []) => {
     throw new ApplicationError('You cannot delete the super admin role');
   }
 
-  for (let roleId of ids) {
+  for (const roleId of ids) {
     const usersCount = await getUsersCount(roleId);
     if (usersCount !== 0) {
       throw new ApplicationError('Some roles are still assigned to some users');

packages/core/admin/server/tests/admin-auth.test.e2e.js

@@ -7,7 +7,7 @@ const { createUtils } = require('../../../../../test/helpers/utils');
 
 const edition = process.env.STRAPI_DISABLE_EE === 'true' ? 'CE' : 'EE';
 
-let internals = {
+const internals = {
   role: null,
 };
 

packages/core/admin/server/tests/admin-permission.test.e2e.js

@@ -21,7 +21,7 @@ describe('Role CRUD End to End', () => {
   });
 
   test('Can get the existing permissions', async () => {
-    let res = await rq({
+    const res = await rq({
       url: '/admin/permissions',
       method: 'GET',
     });

packages/core/admin/server/tests/admin-permissions-conditions.test.e2e.js

@@ -13,7 +13,7 @@ if (edition === 'EE') {
     let strapi;
     let utils;
     const builder = createTestBuilder();
-    let requests = {
+    const requests = {
       public: null,
       admin: null,
     };

packages/core/admin/server/tests/admin-role.test.e2e.js

@@ -255,7 +255,7 @@ describe('Role CRUD End to End', () => {
       ];
 
       test.each(rolesToCreate)('can create %p', async role => {
-        let res = await rq({
+        const res = await rq({
           url: '/admin/roles',
           method: 'POST',
           body: role,
@@ -465,7 +465,7 @@ describe('Role CRUD End to End', () => {
             },
           });
 
-          for (let role of roles) {
+          for (const role of roles) {
             res = await rq({
               url: `/admin/roles/${role.id}`,
               method: 'GET',
@@ -506,7 +506,7 @@ describe('Role CRUD End to End', () => {
           expect(res.statusCode).toBe(200);
           expect(res.body.data).toMatchObject(roles);
 
-          for (let roleId of rolesIds) {
+          for (const roleId of rolesIds) {
             res = await rq({
               url: `/admin/roles/${roleId}`,
               method: 'GET',

packages/core/admin/server/tests/admin-user.test.e2e.js

@@ -39,7 +39,7 @@ describe('Admin User CRUD (e2e)', () => {
   let strapi;
 
   // Local test data used across the test suite
-  let testData = {
+  const testData = {
     firstSuperAdminUser: undefined,
     otherSuperAdminUsers: [],
     user: undefined,

packages/core/admin/server/validation/common-functions/check-fields-are-correctly-nested.js

@@ -6,7 +6,8 @@ const checkFieldsAreCorrectlyNested = fields => {
   if (_.isNil(fields)) {
     // Only check if the fields exist
     return true;
-  } else if (!Array.isArray(fields)) {
+  }
+  if (!Array.isArray(fields)) {
     return false;
   }
 

packages/core/admin/server/validation/common-functions/check-fields-dont-have-duplicates.js

@@ -6,7 +6,8 @@ const checkFieldsDontHaveDuplicates = fields => {
   if (_.isNil(fields)) {
     // Only check if the fields exist
     return true;
-  } else if (!Array.isArray(fields)) {
+  }
+  if (!Array.isArray(fields)) {
     return false;
   }
 

packages/core/admin/webpack.config.dev.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const path = require('path');
-const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;
+const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
 const { DuplicateReporterPlugin } = require('duplicate-dependencies-webpack-plugin');
 const getPluginsPath = require('./utils/get-plugins-path');
 const webpackConfig = require('./webpack.config');

packages/core/admin/webpack.config.js

@@ -56,7 +56,7 @@ module.exports = ({
 
   return {
     mode: isProduction ? 'production' : 'development',
-    bail: isProduction ? true : false,
+    bail: !!isProduction,
     devtool: isProduction ? false : 'eval-source-map',
     experiments: {
       topLevelAwait: true,

packages/core/content-manager/server/services/utils/configuration/layouts.js

@@ -79,12 +79,12 @@ function syncLayouts(configuration, schema) {
 
   let cleanEditRelations = editRelations.filter(attr => hasRelationAttribute(schema, attr));
 
-  let elementsToReAppend = [];
+  const elementsToReAppend = [];
   let cleanEdit = [];
-  for (let row of edit) {
-    let newRow = [];
+  for (const row of edit) {
+    const newRow = [];
 
-    for (let el of row) {
+    for (const el of row) {
       if (!hasEditableAttribute(schema, el.name)) continue;
 
       /* if the type of a field was changed (ex: string -> json) or a new field was added in the schema
@@ -153,11 +153,11 @@ const appendToEditLayout = (layout = [], keysToAppend, schema) => {
     layout[currentRowIndex] = [];
   }
 
-  for (let key of keysToAppend) {
+  for (const key of keysToAppend) {
     const attribute = schema.attributes[key];
 
     const attributeSize = getDefaultFieldSize(attribute.type);
-    let currenRowSize = rowSize(layout[currentRowIndex]);
+    const currenRowSize = rowSize(layout[currentRowIndex]);
 
     if (currenRowSize + attributeSize > MAX_ROW_SIZE) {
       currentRowIndex += 1;

packages/core/content-manager/server/services/utils/configuration/metadatas.js

@@ -91,7 +91,7 @@ async function syncMetadatas(configuration, schema) {
     const { edit, list } = metasWithDefaults[key];
     const attr = schema.attributes[key];
 
-    let updatedMeta = { edit, list };
+    const updatedMeta = { edit, list };
     // update sortable attr
     if (list.sortable && !isSortable(schema, key)) {
       _.set(updatedMeta, ['list', 'sortable'], false);

packages/core/content-manager/server/tests/api/basic-compo-repeatable.test.e2e.js

@@ -7,7 +7,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   productsWithCompo: [],
 };
 

packages/core/content-manager/server/tests/api/basic-compo.test.e2e.js

@@ -7,7 +7,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   productsWithCompo: [],
 };
 

packages/core/content-manager/server/tests/api/basic-dp-compo-repeatable.test.e2e.js

@@ -9,7 +9,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   productsWithCompoAndDP: [],
 };
 

packages/core/content-manager/server/tests/api/basic-dp-compo.test.e2e.js

@@ -9,7 +9,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   productsWithCompoAndDP: [],
 };
 

packages/core/content-manager/server/tests/api/basic-dp-dz.test.e2e.js

@@ -9,7 +9,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   productsWithDzAndDP: [],
 };
 

packages/core/content-manager/server/tests/api/basic-dp.test.e2e.js

@@ -9,7 +9,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   productsWithDP: [],
 };
 
@@ -161,7 +161,7 @@ describe('CM API - Basic + draftAndPublish', () => {
   test('Publish a product, expect publishedAt to be defined', async () => {
     const entry = data.productsWithDP[0];
 
-    let { body } = await rq({
+    const { body } = await rq({
       url: `/content-manager/collection-types/api::product-with-dp.product-with-dp/${entry.id}/actions/publish`,
       method: 'POST',
     });
@@ -174,7 +174,7 @@ describe('CM API - Basic + draftAndPublish', () => {
   test('Publish article1, expect article1 to be already published', async () => {
     const entry = data.productsWithDP[0];
 
-    let { body } = await rq({
+    const { body } = await rq({
       url: `/content-manager/collection-types/api::product-with-dp.product-with-dp/${entry.id}/actions/publish`,
       method: 'POST',
     });
@@ -193,7 +193,7 @@ describe('CM API - Basic + draftAndPublish', () => {
   test('Unpublish article1, expect article1 to be set to null', async () => {
     const entry = data.productsWithDP[0];
 
-    let { body } = await rq({
+    const { body } = await rq({
       url: `/content-manager/collection-types/api::product-with-dp.product-with-dp/${entry.id}/actions/unpublish`,
       method: 'POST',
     });
@@ -206,7 +206,7 @@ describe('CM API - Basic + draftAndPublish', () => {
   test('Unpublish article1, expect article1 to already be a draft', async () => {
     const entry = data.productsWithDP[0];
 
-    let { body } = await rq({
+    const { body } = await rq({
       url: `/content-manager/collection-types/api::product-with-dp.product-with-dp/${entry.id}/actions/unpublish`,
       method: 'POST',
     });

packages/core/content-manager/server/tests/api/basic-dz.test.e2e.js

@@ -7,7 +7,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   productsWithDz: [],
 };
 

packages/core/content-manager/server/tests/api/basic-relations.test.e2e.js

@@ -8,7 +8,7 @@ let strapi;
 let rq;
 const builder = createTestBuilder();
 
-let data = {
+const data = {
   stamps: [],
   collectors: [],
 };

packages/core/content-manager/server/tests/api/basic.test.e2e.js

@@ -9,7 +9,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   products: [],
 };
 

packages/core/content-manager/server/tests/api/populate-dz.test.e2e.js

@@ -7,7 +7,7 @@ const { createAuthRequest } = require('../../../../../../test/helpers/request');
 const builder = createTestBuilder();
 let strapi;
 let rq;
-let data = {
+const data = {
   productsWithDz: [],
   categories: [],
 };

packages/core/content-manager/server/tests/api/x-to-many-rf-preview.test.e2e.js

@@ -168,7 +168,7 @@ describe('x-to-many RF Preview', () => {
   describe('Relation Nature', () => {
     test(`Throws if the relation's nature is not a x-to-many`, async () => {
       const url = getCMPrefixUrl(categoryModel.singularName);
-      const id = data.category[0].id;
+      const { id } = data.category[0];
 
       const { body, statusCode } = await rq.get(`${url}/${id}/product`);