Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally debug all collected versions #1287

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@

# Nimble changelog

## 0.16.3

- Nim dependencies now use precompiled binaries when available. One can opt-out it by using `--disableNimBinaries`.
- Improves sat error messages. Making it easier to spot conflicting dependencies.
- Other fixes and improvements.

## 0.16.2

- Adds a `requires` flag which allows to add extra packages to the dependency resolution.
Expand Down
2 changes: 1 addition & 1 deletion nimble.nimble
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Package

version = "0.16.2"
version = "0.16.3"
author = "Dominik Picheta"
description = "Nim package manager."
license = "BSD"
Expand Down
10 changes: 9 additions & 1 deletion src/nimblepkg/nimblesat.nim
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ when defined(nimNimbleBootstrap):
else:
import sat/[sat, satvars]
import version, packageinfotypes, download, packageinfo, packageparser, options,
sha1hashes, tools, downloadnim
sha1hashes, tools, downloadnim, cli

import std/[tables, sequtils, algorithm, sets, strutils, options, strformat, os]

Expand Down Expand Up @@ -494,6 +494,14 @@ proc solvePackages*(rootPkg: PackageInfo, pkgList: seq[PackageInfo], pkgsToInsta
var pkgVersionTable = initTable[string, PackageVersions]()
pkgVersionTable[root.name] = PackageVersions(pkgName: root.name, versions: @[root])
collectAllVersions(pkgVersionTable, root, options, downloadMinimalPackage, pkgList.mapIt(it.getMinimalInfo(options)))
if options.verbosity <= DebugPriority:
display("Info", "Collected packages", priority = DebugPriority)
for k, v in pkgVersionTable:
display("Info", k, priority = DebugPriority)
for ver in v.versions:
for dep in ver.requires:
display("Info", &"\t {dep.name} {dep.ver}", priority = DebugPriority)

solvedPkgs = pkgVersionTable.getSolvedPackages(output).topologicalSort()

for solvedPkg in solvedPkgs:
Expand Down
Loading