expand tester's features
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prepare the tester for supporting an arbitrary number of output fragments * the runner signals the end of an output fragment via the `!BREAK!` string * more fragments than what the specification requires is not an error * the `output` specification specifies what the *last* output fragment has to be * a file with the `.expected` extension and the same name as the test specifies and additional output fragment
saem
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
arguments)specification
Details
output fragments
!BREAK!substring in therunner's output
outputspecification specifies what the last output fragmenthas to be
.expectedextension and the same name as the testspecifies an additional output fragment
Notes For Reviewers
Both features are a preparation for implementing bytecode output comparison for the
pass0tests in #7. The idea is that the expected bytecode is provided by at0x_xxx.expectedfile alongside the main test file.The various expected output fragments could also be specified via the test specification (like how tests in NimSkull usually do it), but this tends to be awkward to read (i.e., the expected output comes before the actual test). Having the expected output be part of the test file but appear after the main test content could work, but using a separate file was somewhat simpler to implement.