web-client: Enable HD wallet key derivation #2715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
added
WASM
pow-compatibility
sisou
force-pushed
the
soeren/web-client-key-derivation
branch
4 times, most recently
from
182d489
to
8d5d3a1
Compare
sisou
force-pushed
the
soeren/web-client-key-derivation
branch
from
8d5d3a1
to
a3474e8
Compare
Eligioo
reviewed
Jul 12, 2024
| let rounds = 2u32.pow(rounds_log as u32); | ||
|
|
||
| match version { | ||
| 1 => unimplemented!(), |
There was a problem hiding this comment.
Are we going to fully discard older versions?
There was a problem hiding this comment.
The older versions use a KDF OTP function that core-rs-albatross no longer implements.
Eligioo
reviewed
Jul 17, 2024
sisou
force-pushed
the
soeren/web-client-key-derivation
branch
8 times, most recently
from
59fabbf
to
afa49dd
Compare
The encryption is PoW-backward-compatible (using the Argon2d algorithm).
That way these classes can be tree-shaken and do not blow up WASM size when not used. Move CryptoUtils.otpKdf function into an auto-spawning worker, so it doesn't block the main thread, as it usually takes a few seconds to run, other than the other methods on the class.
Copied the relevant tests from core-js.
Wrapping String.prototype.isWellFormed or a replacement taken from the official polyfill.
sisou
force-pushed
the
soeren/web-client-key-derivation
branch
from
afa49dd
to
3103f08
Compare
sisou
added a commit
that referenced
this pull request
Oct 18, 2024
`wasm-pack build` runs wasm-opt automatically, which currently fails for an unknown reason. The wasm tests are run with `wasm-pack test`, which compiles to a debug target and doesn't use wasm-opt, so doesn't trigger the problem. The actual build will be tested as part of PR #2715.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add classes/structs and methods to support HD wallet key derivation as was possible with the core-js library.