Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockchain: add network_id to SkipBlockInfo #2997

Open
wants to merge 1 commit into
base: albatross
Choose a base branch
from
Open

Blockchain: add network_id to SkipBlockInfo #2997

wants to merge 1 commit into from
+14 −1

Conversation

styppo
Copy link
Member

@styppo styppo commented Oct 23, 2024

Add network_id to SkipBlockInfo to prevent usage of the skip block signature across networks.

@Eligioo Eligioo added the testnet-restart Change breaks the protocol and requires a testnet restart label Oct 23, 2024
hrxi
hrxi reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@hrxi hrxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The network_id probably needs to be checked somewhere, too.

@styppo
Copy link
Member Author

styppo commented Oct 25, 2024

The network_id is implicitly verified here as the signed message (SkipBlockInfo) is constructed from the network_id given in the block header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrxi hrxi hrxi left review comments

Assignees
No one assigned
Labels
testnet-restart Change breaks the protocol and requires a testnet restart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@styppo @hrxi @Eligioo