-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply transforms to raw data when MNI6 derivatives aren't available #58
Conversation
# Resample BOLD to MNI152NLin6Asym, may duplicate bold_std_wf above | ||
# XXX: Ignoring the field map for now | ||
# (inputnode, bold_MNI6_wf, [ | ||
# ('fmap_ref', 'inputnode.fmap_ref'), | ||
# ('fmap_coeff', 'inputnode.fmap_coeff'), | ||
# ('fmap_id', 'inputnode.fmap_id'), | ||
# ]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to figure out how to grab the field map
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 31.40% 31.08% -0.32%
==========================================
Files 26 26
Lines 2277 2329 +52
Branches 360 362 +2
==========================================
+ Hits 715 724 +9
- Misses 1541 1584 +43
Partials 21 21 ☔ View full report in Codecov by Sentry. |
I realized I wasn't passing along the STCed BOLD data to the MNI6 workflow, so I fixed that, but it didn't bring the results in line with the MNI6-derivatives outputs. |
The transforms being used for the
Comparing to what's in the fMRIPrep working directory (they're the same!):
|
Okay, I think it's an issue in the Docker image. I ran ResampleSeries locally and the results look good for boldref-to-T1w-to-MNI6 and orig-to-boldref-to-T1w-to-MNI6. I then tried it on the same files, with the same commands, in the Docker image, and, while boldref-to-T1w-to-MNI6 looks good, orig-to-boldref-to-T1w-to-MNI6 does not. So basically the HMC part is not operating correctly within the Docker image. I assume the problem is buried in one of the Python dependencies in my Docker image. |
@effigies I bumped my local nitransforms from 23.0.1 to 24.0.0 and the orig-to-boldref-to-T1w-to-MNI6 result started looking bad. Is there some chance an issue with using fMRIPrep's HMC transforms was introduced in nitransforms 24.0.0? |
Can you decompose that? I don't think anything should have changed in HMC, but we did fix the parsing of the ITK warps, which might have broken our workaround in nipreps... |
I can create a minimal reproducible example, probably. Here's a more linear summary:
|
Okay. Damn. We probably need to roll back nitransforms in the fmriprep 24.1.0 branch. |
Actually, would you mind re-testing with fmriprep 24.1.0rc0, to verify that the problem exhibits there as well? |
I can run the subject through the full pipeline later today, but in case it's informative, I pulled nipreps/fmriprep:24.0.0 and nipreps/fmriprep:24.1.0rc0 and ran just the ResampleSeries command with those. The results look good for 24.0.0, but not for 24.1.0rc0. |
I've got fMRIPrep running with 24.1.0rc0 and I'll update this thread with my results once it finishes. The good news is that I pinned |
We're having server issues right now so it might be a few days before I can resubmit my fMRIPrep 24.1.0rc0 job. |
Closes #57. I tested this locally against running with MNI6 derivatives, and the results are different. I am a little worried that I didn't implement the transforms properly or something.
To do:
Changes proposed in this pull request
ignore
to the Config object so users can actually ignore stuff.mem_gb
to SUSAN and MELODIC nodes to avoid memory errors #11).init_bold_volumetric_resample_wf
, using raw BOLD and derivatives I think should be available at least infull
mode with--cifti-output
.