Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf(py314): Replace deprecated pkgutil.find_loader #13

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

effigies
Copy link
Member

This PR removes pkgutil.find_loader() and replaces it with importlib.util.find_spec(). find_loader was deprecated in Python 3.12 and will be removed in 3.14. find_spec has been present since Python 3.4.

Both functions return None if the module loader cannot be found. For its use in this project, this is sufficient and no translation of the return value is needed.

Copy link

codecov bot commented Oct 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Collaborator

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because nothing's actually in working order yet, so you can ignore that.

@tsalo tsalo merged commit bcf8f65 into nipreps:main Oct 17, 2024
2 of 11 checks passed
@effigies effigies deleted the rf/drop-pkgutil-find_loader branch October 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants