Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Specify Python version for ruff #1376

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jhlegarreta
Copy link
Contributor

Specify Python version for ruff: use Python 3.10 as a reasonable choice.

Fixes:

ruff
The `python-version` input is not set. The version of Python currently in `PATH` will be used.

raised for example at:
https://github.com/nipreps/mriqc/actions/runs/12795005155

Specify Python version for `ruff`: use Python 3.10 as a reasonable
choice.

Fixes:
```
ruff
The `python-version` input is not set. The version of Python currently in `PATH` will be used.
```

raised for example at:
https://github.com/nipreps/mriqc/actions/runs/12795005155
@oesteban oesteban merged commit 61afec8 into nipreps:master Jan 16, 2025
14 checks passed
@jhlegarreta jhlegarreta deleted the SpecifyPythonVersionForRuff branch January 16, 2025 13:46
@jhlegarreta
Copy link
Contributor Author

Looks like it did not fix the issue, sorry:
https://github.com/nipreps/mriqc/actions/runs/12806666145

Will not be able to revisit this in the coming days. Apologies for that.

@effigies
Copy link
Member

That has nothing to do with ruff (which uses requires-python so doesn't need target-version set), but is emitted by setup-python. That is just warning us that we're not specifying python-version in

- name: Set up Python
uses: actions/setup-python@v5

This isn't a problem, it just means we get the default. We could also just remove this, however, since pipx is already present without running setup-python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants