ENH: Refactor filters into filtering
#71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few comments:
|
jhlegarreta
force-pushed
the
RefactorFilteringCode
branch
from
5cec644 to
7e67f76
Compare
jhlegarreta
commented
Jan 25, 2025
| reference = np.percentile(centers[centers >= 1.0], DEFAULT_CLIP_PERCENTILE) | ||
| centers[centers < 1.0] = reference | ||
| drift = reference / centers | ||
| return shelldata * drift |
There was a problem hiding this comment.
Naming for above two functions/filters should be improved.
jhlegarreta
force-pushed
the
RefactorFilteringCode
branch
from
7e67f76 to
1170199
Compare
Refactor code blocks that perform filtering operations within models into the `filtering` module so that the model and filter concepts are separated, supporting more cleanly pipelining models with filters within the new `Estimator` philosophy. Add the percentile-based detrending feature that was temporarily removed in commit 7322e93.
jhlegarreta
force-pushed
the
RefactorFilteringCode
branch
from
1170199 to
504ea30
Compare
jhlegarreta
commented
Jan 25, 2025
|
|
||
| clipped_dataset._dataset = clipped_dataset._dataset.dataobj[..., shellmask] | ||
|
|
||
| return clipped_dataset |
There was a problem hiding this comment.
If we clip the data, maybe the gradients stored in the datasets should also be clipped.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 68.75% 67.35% -1.40%
==========================================
Files 20 20
Lines 957 965 +8
Branches 121 120 -1
==========================================
- Hits 658 650 -8
- Misses 254 271 +17
+ Partials 45 44 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code blocks that perform filtering operations within models into the
filteringmodule so that the model and filter concepts are separated, supporting more cleanly pipelining models with filters within the newEstimatorphilosophyAdd the percentile-based detrending feature that was temporarily removed in commit 7322e93.
Closes #63.