Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a custom seqinfo to extract from DICOMs any additional metadata desired for a heuristic #581

Merged
merged 18 commits into from
Feb 28, 2024

Provide types for custom_seqinfo but disable type checking in the tes…

41b22d7
Select commit
Loading
Failed to load commit list.
Merged

Add support for a custom seqinfo to extract from DICOMs any additional metadata desired for a heuristic #581

Provide types for custom_seqinfo but disable type checking in the tes…
41b22d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 28, 2024 in 0s

82.04% (-0.01%) compared to 153d522, passed because coverage increased by +0.00% when compared to adjusted base (82.03%)

View this Pull Request on Codecov

82.04% (-0.01%) compared to 153d522, passed because coverage increased by +0.00% when compared to adjusted base (82.03%)

Details

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.04%. Comparing base (153d522) to head (41b22d7).

Files Patch % Lines
heudiconv/dicoms.py 72.72% 3 Missing ⚠️
heudiconv/heuristics/convertall_custom.py 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   82.05%   82.04%   -0.01%     
==========================================
  Files          41       42       +1     
  Lines        4173     4205      +32     
==========================================
+ Hits         3424     3450      +26     
- Misses        749      755       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.