Skip to content

Commit

Permalink
Merge pull request #1380 from effigies/fix/mrs_type
Browse files Browse the repository at this point in the history
FIX: Set MRS type to Nifti1Extension for backwards compatibility
  • Loading branch information
effigies authored Oct 23, 2024
2 parents 96c8320 + 56446e5 commit 7b5060e
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
17 changes: 14 additions & 3 deletions Changelog
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ Eric Larson (EL), Demian Wassermann, Stephan Gerhard and Ross Markello (RM).

References like "pr/298" refer to github pull request numbers.

5.3.2 (Wednesday 23 October 2024)
=================================

Bug-fix release in the 5.3.x series.

Bug fixes
---------
* Restore MRS extension type to Nifti1Extension to maintain backwards compatibility.
(pr/1380) (CM)


5.3.1 (Tuesday 15 October 2024)
===============================

Expand All @@ -46,9 +57,9 @@ NiBabel 6.0 will drop support for Numpy 1.x.

New features
------------
* Update NIfTI extension protocol to include ``.content : bytes``, ``.text : str`` and ``.json : dict``
properties for accessing extension contents. Exceptions will be raised on ``.text`` and ``.json`` if
conversion fails. (pr/1336) (CM)
* Update NIfTI extension protocol to include ``.content : bytes``, ``.text : str`` and
``.json() : dict`` properties/methods for accessing extension contents.
Exceptions will be raised on ``.text`` and ``.json()`` if conversion fails. (pr/1336) (CM)

Enhancements
------------
Expand Down
2 changes: 1 addition & 1 deletion nibabel/nifti1.py
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ def _mangle(self, dataset: DicomDataset) -> bytes:
(38, 'eval', NiftiExtension),
(40, 'matlab', NiftiExtension),
(42, 'quantiphyse', NiftiExtension),
(44, 'mrs', NiftiExtension[dict[str, ty.Any]]),
(44, 'mrs', Nifti1Extension),
),
fields=('code', 'label', 'handler'),
)
Expand Down

0 comments on commit 7b5060e

Please sign in to comment.