STY: Enforce ruff/flake8-pytest-style rules (PT) #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
PT
branch
from
ca871a6 to
f81ec73
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1356 +/- ##
=======================================
Coverage 95.36% 95.37%
=======================================
Files 207 207
Lines 29680 29674 -6
Branches 4992 4993 +1
=======================================
- Hits 28305 28301 -4
+ Misses 935 933 -2
Partials 440 440 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Sep 22, 2024
DimitriPapadopoulos
force-pushed
the
PT
branch
4 times, most recently
from
64d47ec to
75fc219
Compare
effigies
reviewed
Sep 23, 2024
nibabel/cmdline/tests/test_roi.py
Outdated
Comment on lines
143
to
146
| except SystemExit: | ||
| pass | ||
| else: | ||
| assert False, 'argparse exits on --help. If changing to another parser, update test.' | ||
| pytest.fail('argparse exits on --help. If changing to another parser, update test.') |
There was a problem hiding this comment.
I think the whole try/except/else block should be:
with pytest.raises(SystemExit):
main()There was a problem hiding this comment.
I (think I) applied your suggestion.
DimitriPapadopoulos
force-pushed
the
PT
branch
from
75fc219 to
4af11a1
Compare
PT006 Wrong type passed to first argument of `@pytest.mark.parametrize`; expected `tuple`
PT014 Duplicate of test case
PT015 Assertion always fails, replace with `pytest.fail()`
PT017 Found assertion on exception `err` in `except` block, use `pytest.raises()` instead
PT022 No teardown in fixture `db`, use `return` instead of `yield`
PT027 Use `pytest.raises` instead of unittest-style `assertRaises`
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
|
Failures seem related to scipy/scipy#21623. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.