Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Slightly simplify frame_indices array construction #1404

Closed
wants to merge 1 commit into from

Conversation

effigies
Copy link
Member

Turning #1387 (comment) into a PR.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (f81f5a7) to head (df638fd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1404      +/-   ##
==========================================
- Coverage   95.34%   95.34%   -0.01%     
==========================================
  Files         208      208              
  Lines       29774    29772       -2     
  Branches     3356     3355       -1     
==========================================
- Hits        28387    28385       -2     
  Misses        948      948              
  Partials      439      439              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the enh/atleast2d-frame-indices branch from b0ca59b to df638fd Compare January 12, 2025 16:46
@effigies
Copy link
Member Author

My initial proposal turned out to be wrong, as atleast_2d adds dimensions to the front instead of the back. This instead maps atleast_1d over the arrays that are scalar or 1d, which feels slightly clearer in intent to me, but not so much that I'd insist on this.

Closing as not worth the churn.

@effigies effigies closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant