Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ruff, address complaints #1405

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Conversation

effigies
Copy link
Member

The churn machine demands churn.

@effigies
Copy link
Member Author

@DimitriPapadopoulos Care to have a look?

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.34%. Comparing base (f81f5a7) to head (eaa7200).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
nibabel/cmdline/dicomfs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
- Coverage   95.34%   95.34%   -0.01%     
==========================================
  Files         208      208              
  Lines       29774    29768       -6     
  Branches     3356     3355       -1     
==========================================
- Hits        28387    28381       -6     
  Misses        948      948              
  Partials      439      439              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented Jan 13, 2025

Finally, perhaps these rules could be enabled:

    "ISC001",
    "ISC002",

Indeed, the documentation has been updated under Conflicting lint rules in astral-sh/ruff#15123 / astral-sh/ruff@b76d05e, in time for 0.9.1:

multi-line-implicit-string-concatenation (ISC002) if used without ISC001 and flake8-implicit-str-concat.allow-multiline = false

The default value of lint.flake8-implicit-str-concat.allow-multiline is true.

@effigies effigies merged commit 5aca3f2 into nipy:master Jan 14, 2025
41 of 42 checks passed
@effigies effigies deleted the chore/ruff branch January 14, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants