Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates after pre-commit autoupdate #1406

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

Following 3910275 and eaa7200, update pre-commit configuration and apply new ruff rules.

Starting with ruff 0.9.1, ISC001 and ISC002 linter rules are compatible
with the formatter when used together. There is no need to apply ISC001
once again after running the formatter.
RUF039 First argument to `re.compile()` is not raw string
RUF039 First argument to `re.sub()` is not raw string
RUF043 Pattern passed to `match=` contains metacharacters but is neither escaped nor raw
RUF046 Value being cast to `int` is already an integer
RUF052 Local dummy variable is accessed
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.34%. Comparing base (5aca3f2) to head (e22675f).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
nibabel/nicom/dicomwrappers.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1406   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files         208      208           
  Lines       29768    29768           
  Branches     3355     3355           
=======================================
  Hits        28381    28381           
  Misses        948      948           
  Partials      439      439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

Thanks!

@effigies effigies merged commit 9d66d8a into nipy:master Jan 16, 2025
42 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the ruff_0.9.1 branch January 16, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants