Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error running workflows with updatehash=True #3709

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mauriliogenovese
Copy link
Contributor

@mauriliogenovese mauriliogenovese commented Jan 19, 2025

Any workflow running with updatehash=True will crash

That happens because in nodes.py line 457 we try to update the hashfile even if the node was never executed before, so no hashfile is found and _update_hash function raises an exception.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (bc456dd) to head (88e30f8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3709   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files        1278     1278           
  Lines       59356    59357    +1     
=======================================
+ Hits        43359    43360    +1     
  Misses      15997    15997           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Small logic simplification.

nipype/pipeline/engine/nodes.py Outdated Show resolved Hide resolved
@mauriliogenovese
Copy link
Contributor Author

I add another commit to keep multi process functionality with updatehash=True.
Maybe there is a more elegant way to address it, but it seems to work in my tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants