Skip to content

Commit

Permalink
Shorten ip address lookup timeout
Browse files Browse the repository at this point in the history
In the CI this completes now in 1m30s, so 3m is long enough to avoid
flaky tests. Locally this takes less than 10 seconds.
  • Loading branch information
nirs committed Feb 24, 2025
1 parent 83f952a commit d59889f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
source .venv/bin/activate
./example test --driver ${{ matrix.driver }} --connection ${{ matrix.connection }} -v &
vm="$HOME/.vmnet-helper/vms/test"
if ! timeout 5m bash -c "until test -f "$vm/ip-address"; do sleep 3; done"; then
if ! timeout 3m bash -c "until test -f "$vm/ip-address"; do sleep 3; done"; then
echo >&2 "Timeout waiting for $vm/ip-address"
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion vmnet/vm.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def write_command(self, cmd):
with open(path, "w") as f:
f.write(data)

def wait_for_ip_address(self, timeout=300):
def wait_for_ip_address(self, timeout=180):
"""
Lookup the vm ip address in the serial log and write to
vm_home/ip-address.
Expand Down

0 comments on commit d59889f

Please sign in to comment.