Support more distros in the example #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nirs
commented
Jan 25, 2025
nirs
commented
- Pass command line arguments to most functions to clean up the code and make it easier to extend later.
- Add support for multiple distros
- Add fedora and alpine images
We have too many arguments, passing args cleans up the code and make it easier to extend.
Like start_helper, passing args simplifies the code and make it easier to extend.
Currently using only args.vm_name, but with this change will make them easy to modify to support other options.
This will probably never need anything else but args.vm_name, but it is more consistent with similar functions.
For consistency with other function and for adding special handling per distro.
Add --distro argument, preparing for adding more distros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.