-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implement update user API client and apply it to rename user form #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kanta1207
Thank you for the implementation! I left a comment, so please take a look. Other than that, this PR looks very good 😊
/** | ||
* Interface representing the request body for the function to update user's data. | ||
* @property name - The name of the user. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rewrite the TSDoc, please? This is not the official way.
#247
Instead, please add a description to the line right above each property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kanta1207
Thank you for fixing them! LGTM 👍
@nick-y-ito |
Overview
Implement
Update user
API client, and apply it to rename user form to rename user.I didn't add refresh feature in this PR
Changes
user.ApiClient.client.ts
renameUser
actionRenameUserForm
Screen Captures
Screen.Recording.2024-03-11.at.23.54.50.mov
Assignee Checklist:
Reviewer Checklist: