Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implement update user API client and apply it to rename user form #352

Merged
merged 14 commits into from
Mar 12, 2024

Conversation

kanta1207
Copy link
Member

@kanta1207 kanta1207 commented Mar 11, 2024

Overview

Implement Update user API client, and apply it to rename user form to rename user.
I didn't add refresh feature in this PR

Changes

  • Add API client in user.ApiClient.client.ts
  • Add renameUser action
  • Apply it to RenameUserForm

Screen Captures

Screen.Recording.2024-03-11.at.23.54.50.mov

Assignee Checklist:

  • The naming convention of the PR title is correct (See the comment at the top of this template)
  • The base branch is correct (See: Types of Branches)
  • The branch name follows the Branch Naming Conventions
  • The correct assignees and reviewers have been designated for this PR
  • The coding style follows the Coding Style Guide
  • All the related issues are associated with this PR
  • All criteria in the associated issues are met (please tick the checkboxes)
  • My changes do not generate new warnings or errors (especially in the console)

Reviewer Checklist:

  • Double-check the "Assignee Checklist"
  • The code follows the generic best practices and our Coding Style Guide
  • The code is well-commented and easy to understand
  • The UI changes accurately reflect the provided design

@kanta1207 kanta1207 linked an issue Mar 11, 2024 that may be closed by this pull request
2 tasks
@kanta1207 kanta1207 changed the title Feature/340 update user api client Feat: Implement update user API client and apply it to rename user form Mar 11, 2024
@kanta1207 kanta1207 self-assigned this Mar 11, 2024
@kanta1207 kanta1207 requested a review from nick-y-ito March 12, 2024 06:55
@kanta1207 kanta1207 marked this pull request as ready for review March 12, 2024 07:00
@kanta1207 kanta1207 requested a review from ShoeheyOt March 12, 2024 07:04
Copy link
Member

@nick-y-ito nick-y-ito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanta1207
Thank you for the implementation! I left a comment, so please take a look. Other than that, this PR looks very good 😊

/**
* Interface representing the request body for the function to update user's data.
* @property name - The name of the user.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rewrite the TSDoc, please? This is not the official way.
#247

Instead, please add a description to the line right above each property.

Copy link
Member

@nick-y-ito nick-y-ito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanta1207
Thank you for fixing them! LGTM 👍

@kanta1207
Copy link
Member Author

@nick-y-ito
Thank you for the review and quick approval!
I deleted @property tag and instead wrote a comment above the property. (Didn't do the refactoring for all of the other @property tag, tho)

@kanta1207 kanta1207 merged commit 6060dbe into develop Mar 12, 2024
5 checks passed
@kanta1207 kanta1207 deleted the feature/340-update-user-api-client branch March 12, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Update User API client, and apply it to Profile page to rename user
2 participants