Add support for data object #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishtahir
reviewed
Oct 31, 2023
src/keywords.YAML-tmLanguage
Outdated
| @@ -44,7 +44,7 @@ repository: | |||
| match: \b(constructor|init)\b | |||
| name: entity.name.function.constructor | |||
| - | |||
| match: \b(companion|object)\b | |||
| match: \b(companion|object|data\s+object)\b | |||
There was a problem hiding this comment.
Thanks for your contribution. I'm assuming that this change is motivated by https://kotlinlang.org/docs/object-declarations.html#data-objects. I'd rather have data tagged independently as a storage modifier than make data object as a single keyword. I think the correct place to make the adjustment would be making the change here
There was a problem hiding this comment.
So I did so, hopefully, it is correct now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 68.40% 68.40%
=======================================
Files 13 13
Lines 500 500
=======================================
Hits 342 342
Misses 158 158 ☔ View full report in Codecov by Sentry. |
nishtahir
approved these changes
Nov 18, 2023
nishtahir
added a commit
that referenced
this pull request
Nov 18, 2023
* add support for data object (#71) * Add update to corpus and regression test --------- Co-authored-by: Jan Škrášek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.