Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marshal variables #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

trojanc
Copy link

@trojanc trojanc commented Feb 4, 2025

Motivation/Abstract

please describe in 1-3 sentences,

Examples: This is a bug fix for ... ; I want to use this BPMN extension attributes 'X' for my project 'Y'...

Description/Comments

In this PR I added marshaling for VariableHolder when the engine is marshaled and unmarshaled
A unit test is also provided to confirm if the engine is loaded correctly after being marshaled

Something abnormal that I did:
I moved VariableHolder to the bpmn_engine package. This was to avoid having to put marshaling code in the var_holder/holder.go file. I felt like these files are kept so clean with the all the marshaling code in the mashalling.go file, I wanted to have the var_holder/holder.go file clean of marshaling logic too. I couldn't reference VariableHolder properly for marshaling from the bpmn_engine package otherwise...

A much smaller change would have been to put the marshaling functions in var_holder/holder.go..

Checklist

Depending on your PR, please ensure the overall consistency/integrity of the project remains.
Please tick just one check item per section below

Tests

  • did you update or create tests for your code changes?
  • not relevant

Code examples

  • did you update or add example code snippets, which relate to your code changes
  • not relevant

Documentation

  • did you update or create documentation, which relates to your code changes
  • not relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant