Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Abstract
please describe in 1-3 sentences,
Examples: This is a bug fix for ... ; I want to use this BPMN extension attributes 'X' for my project 'Y'...
Description/Comments
In this PR I added marshaling for
VariableHolder
when the engine is marshaled and unmarshaledA unit test is also provided to confirm if the engine is loaded correctly after being marshaled
Something abnormal that I did:
I moved VariableHolder to the
bpmn_engine
package. This was to avoid having to put marshaling code in thevar_holder/holder.go
file. I felt like these files are kept so clean with the all the marshaling code in themashalling.go
file, I wanted to have thevar_holder/holder.go
file clean of marshaling logic too. I couldn't referenceVariableHolder
properly for marshaling from thebpmn_engine
package otherwise...A much smaller change would have been to put the marshaling functions in
var_holder/holder.go
..Checklist
Depending on your PR, please ensure the overall consistency/integrity of the project remains.
Please tick just one check item per section below
Tests
Code examples
Documentation