document remove fixed

nitrite · Sep 25, 2024 · 003f847 · 003f847
1 parent 57dbf3c
commit 003f847
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/nitrite/src/main/java/org/dizitart/no2/collection/NitriteDocument.java b/nitrite/src/main/java/org/dizitart/no2/collection/NitriteDocument.java
@@ -367,6 +367,12 @@ private void deepRemove(String[] splits) {
                     // if there are more splits, then this is an embedded document
                     // so remove the element at the next level
                     ((NitriteDocument) item).deepRemove(Arrays.copyOfRange(splits, 2, splits.length));
+                    if (((NitriteDocument) item).size() == 0) {
+                        // if the next level document is an empty one
+                        // remove the element at the current level
+                        list.remove(index);
+                        this.put(key, list);
+                    }
                 } else {
                     // if there are no more splits, then this is a primitive value
                     // so remove the element at the next level

diff --git a/nitrite/src/test/java/org/dizitart/no2/collection/DocumentTest.java b/nitrite/src/test/java/org/dizitart/no2/collection/DocumentTest.java
@@ -201,8 +201,8 @@ public void testRemoveFromArray() {
 
         assertEquals(((List<?>) doc.get("objArray")).size(), 2);
         doc.remove("objArray:0:value");
-        assertEquals(((List<?>) doc.get("objArray")).size(), 2);
-        assertEquals(((Document) doc.get("objArray:0")).size(), 0);
+        assertEquals(((List<?>) doc.get("objArray")).size(), 1);
+        assertEquals(((Document) doc.get("objArray:0")).size(), 1);
     }
 
     @Test