feat: provide config idle timeout for bun runtime. #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` [Bun.serve]: request timed out after 10 seconds. Pass `idleTimeout` to configure. ``` we need to be able to configure idle timeout for bun runtime, because if there are any [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch) inside event handler sometimes need more than 10 seconds. we can leverage built in `NITRO_SHUTDOWN_TIMEOUT ` environment variable to configure this. references: - https://bun.sh/docs/api/http#idletimeout - https://nitro.build/deploy/runtimes/node#environment-variables
pi0
reviewed
Jan 30, 2025
| @@ -12,6 +12,7 @@ const ws = import.meta._websocket | |||
|
|
|||
| // @ts-expect-error | |||
| const server = Bun.serve({ | |||
| idleTimeout: process.env.NITRO_SHUTDOWN_TIMEOUT || 10, | |||
There was a problem hiding this comment.
These are not exactly same options, we need bun specific environment variable for this
There was a problem hiding this comment.
NITRO_BUN_IDLE_TIMEOUT is good for this, isn't it?
btw, luckily, i can use bun patch to overcome this for now. so, no need to rush to fix this as soon as possible in my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to be able to configure idle timeout for bun runtime, because if there are any fetch inside event handler sometimes need more than 10 seconds.
we can leverage built in
NITRO_SHUTDOWN_TIMEOUTenvironment variable to configure this.references:
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist