Enhance volume template to support dynamic values with templating #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated volume template to use `tpl` for processing dynamic values in `.name`, `.originalName`, and `.defaultMode`.
- Improved flexibility by allowing templated strings (e.g., `{{ $.Values.environment }}`) to be resolved during rendering.
- Retained compatibility with existing logic for items and additional properties.
- Added support for dynamic context evaluation, enabling better integration with Helm value overrides.
Replaced `helpers.app.fullname` with `helpers.tplvalues.render` for resolving `claimName` in PVC volumes.
|
Hi, could you provide a specific example of a values file that clearly demonstrates the benefits of this approach, especially in relation to the P.S. In the PR, you added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tplfor processing dynamic values in.name,.originalName, and.defaultMode.{{ $.Values.environment }}) to be resolved during rendering.