Skip to content

Commit

Permalink
Fix performance degradation (#16)
Browse files Browse the repository at this point in the history
* Fix performance degradation

* Bump version to 1.0.2
  • Loading branch information
sgalal authored Mar 24, 2021
1 parent a3901a8 commit f8341fc
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 17 deletions.
8 changes: 4 additions & 4 deletions README-zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
依次加载以下四个 `script` 标签:

```html
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.min.js"></script> <!-- 必须加载 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.cn2t.min.js"></script> <!-- 需要简转繁时 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.t2cn.min.js"></script> <!-- 需要繁转简时 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/bundle-browser.min.js"></script><!-- 必须加载 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.min.js"></script> <!-- 必须加载 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.cn2t.min.js"></script> <!-- 需要简转繁时 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.t2cn.min.js"></script> <!-- 需要繁转简时 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/bundle-browser.min.js"></script><!-- 必须加载 -->
```

**在 Node.js 中加载**
Expand Down
8 changes: 4 additions & 4 deletions README-zh-TW.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
依次載入以下四個 `script` 標籤:

```html
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.min.js"></script> <!-- 必須載入 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.cn2t.min.js"></script> <!-- 需要簡轉繁時 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.t2cn.min.js"></script> <!-- 需要繁轉簡時 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/bundle-browser.min.js"></script><!-- 必須載入 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.min.js"></script> <!-- 必須載入 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.cn2t.min.js"></script> <!-- 需要簡轉繁時 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.t2cn.min.js"></script> <!-- 需要繁轉簡時 -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/bundle-browser.min.js"></script><!-- 必須載入 -->
```

**在 Node.js 中載入**
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ The JavaScript version of Open Chinese Convert (OpenCC)
Import in HTML pages:

```html
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.min.js"></script> <!-- Required -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.cn2t.min.js"></script> <!-- For Simplified to Traditional -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/data.t2cn.min.js"></script> <!-- For Traditional Chinese to Simplified Chinese -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].1/bundle-browser.min.js"></script><!-- Required -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.min.js"></script> <!-- Required -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.cn2t.min.js"></script> <!-- For Simplified to Traditional -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/data.t2cn.min.js"></script> <!-- For Traditional Chinese to Simplified Chinese -->
<script src="https://cdn.jsdelivr.net/npm/[email protected].2/bundle-browser.min.js"></script><!-- Required -->
```

**Import opencc-js in Node.js script**
Expand Down
6 changes: 4 additions & 2 deletions main.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,17 @@ function loadDict(s, type) {
export function Converter(options) {
if (options.from == null) throw new Error('Please provide the `from` option');
if (options.to == null) throw new Error('Please provide the `to` option');
const dictFrom = loadDict(options.from, 'from');
const dictTo = loadDict(options.to, 'to');
/**
* The converter that performs the conversion.
* @param {string} s The string to be converted.
* @returns {string} The converted string.
*/
function convert(s) {
let res = s;
if (options.from !== 't') res = loadDict(options.from, 'from').convert(res);
if (options.to !== 't') res = loadDict(options.to, 'to').convert(res);
if (options.from !== 't') res = dictFrom.convert(res);
if (options.to !== 't') res = dictTo.convert(res);
return res;
}
return convert;
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "opencc-js",
"version": "1.0.1",
"version": "1.0.2",
"description": "The JavaScript version of Open Chinese Convert (OpenCC)",
"main": "bundle-node.js",
"repository": {
Expand Down

0 comments on commit f8341fc

Please sign in to comment.