Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to schemas pr-262 #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update to schemas pr-262 #209

wants to merge 1 commit into from

Conversation

tschaffter
Copy link
Member

  • Update SDK
  • Update client API

Update SDK

The schemas pr-262 adds API key authentication to the data node.

rm -fr docs nlpsandbox test
npx @openapitools/openapi-generator-cli generate -g python -o . --package-name nlpsandbox -i https://nlpsandbox.github.io/nlpsandbox-schemas/_internal/nlpsandbox/pr-262/openapi.json

Note: I noticed that the openapi generator generates the folder test and docs with the above command. Therefore I removed these folders manually before running openapi generator. We may want to do the same in the GH workflow that update the code base. This workflow currently only deleted the folder nlpsandbox.

Update client API

@thomasyu888 Can you please take it from there to update the client API? You will need a local instance of the data node from this PR/branch to test the client. The README of the data node should allow you to do so easily once you have checked out the branch. You can start by testing a DELETE endpoint, which does not requires you to seed the data node.

@tschaffter
Copy link
Member Author

@thomasyu888 Did the tests generated by openapi-generator work out of the box usually?

@thomasyu888
Copy link
Member

@tschaffter This introduces things that make the tools not backwards compatible. The tests also don't work out of the box - we have to fill it in manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants