Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/bump runtime #225

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore/bump runtime #225

merged 1 commit into from
Jul 31, 2024

Conversation

Magnus-Kuhn
Copy link
Contributor

No description provided.

@Magnus-Kuhn Magnus-Kuhn requested a review from jkoenig134 July 31, 2024 08:36
@jkoenig134
Copy link
Member

@Magnus-Kuhn have you checked the diff between these versions?

Copy link
Contributor Author

@Magnus-Kuhn Magnus-Kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Magnus-Kuhn have you checked the diff between these versions?

I initially believed you but now I checked :)
getSharedAttributesFromRequest has made its way into the index.js, so it worked.

@jkoenig134
Copy link
Member

this is not what I meant - if you bump the version here you have to make sure all diffs get added to the dart code. This means you have to check the runtime diff between 4.13.1 and 4.14.2.

@britsta can you make sure to double-check this?

Copy link
Contributor

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine 🐸 FYI, version changes in main of the Runtime were made in the following PRs:

In these and no other PRs that have been merged into main of the Runtime between version 4.13.1 to 4.14.2, I have noticed changes relevant to the App-Runtime bridge.

@Magnus-Kuhn Magnus-Kuhn merged commit 6f79f89 into main Jul 31, 2024
6 checks passed
@Magnus-Kuhn Magnus-Kuhn deleted the chore/bump-runtime branch July 31, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants