-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log event ids introduced for important log statements #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fixed minor typos in log statement messages
chore: fixed minor typos in log statement messages
…nto introduce-log-event-ids
tnotheis
requested changes
Oct 20, 2023
Modules/Devices/src/Devices.Application/Devices/Commands/RegisterDevice/Handler.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Application/Identities/Commands/CreateIdentity/Handler.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Application/Tiers/Commands/CreateTier/Handler.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Infrastructure/PushNotifications/DirectPush/DirectPushService.cs
Outdated
Show resolved
Hide resolved
tnotheis
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
1 How It Works
Specific log event ids accompanied by log event names are added to important log statements to facilitate filtering and search. A pattern involving an
ILogger
extension containing a private delegate and a public method is used, e.g.:This way the methods introduced for logging the events in a certain class are only available in that class.
2 Where Is It Used
Introduced the log event ids as well as corrected occasional typos in the following classes:
CustomExceptionsFilter
,LoggingBehavior
,EventBusAzureServiceBus
,EventBusGoogleCloudPubSub
,DefaultRabbitMQPersisterConnection
,EventBusRabbitMQ
,AzureStorageAccount
,GoogleCloudStorage
,Modules.Devices.Application.Clients.Commands.DeleteClient.Handler
,Modules.Devices.Application.Devices.Commands.ChangePassword.Handler
,Modules.Devices.Application.Devices.Commands.DeleteDevice.Handler
,Modules.Devices.Application.Devices.Commands.RegisterDevice.Handler
,Modules.Devices.Application.Identities.Commands.CreateIdentity.Handler
,Modules.Devices.Application.Tiers.Commands.CreateTier
,AzureNotificationHubPushService
,DirectPushService
,Modules.Files.Jobs.SanityCheck.Infrastructure.Reporter.LogReporter
,Modules.Messages.Jobs.SanityCheck.Infrastructure.Reporter.LogReporter
,IdentityCreatedIntegrationEventHandler
,TierCreatedIntegrationEventHandler
,TierDeletedIntegrationEventHandler
,TierQuotaDefinitionDeletedIntegrationEventHandler
,Quotas.Application.Tiers.Commands.CreateQuotaForIdentity.Handler
,Quotas.Application.Tiers.Commands.CreateQuotaForTier.Handler
,Quotas.Application.Tiers.Commands.DeleteQuotaForIdentity.Handler
,Quotas.Application.Tiers.Commands.DeleteTierQuotaDefinition.Handler
,RelationshipsRepository
,Relationships.Jobs.SanityCheck.RelationshipChange.Infrastructure.Reporter.LogReporter
,Relationships.Jobs.SanityCheck.RelationshipTemplate.Infrastructure.Reporter.LogReporter
,Synchronization.Jobs.SanityCheck.Infrastructure.Reporter.LogReporter
,Tokens.Jobs.SanityCheck.Infrastructure.Reporter.LogReporter
.Complete list with all the introduced log event ids and names will be available in documentation.