Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify aspnet logging #348

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Simplify aspnet logging #348

merged 8 commits into from
Oct 18, 2023

Conversation

tnotheis
Copy link
Member

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

This PR includes the following:

  • It mainly reduces the noise of ASP.NET Core default logs by reducing the log level to Warning and at the same time adding the SerilogRequestLogging middleware, which summarizes each request.
  • I also added "Seq" for local development. Seq is a tool to view structured logs. I added it as a container to the docker-compose stack, so you can now access the logs on locahost:8081.
  • I also increased the default log level from Error to Warning, while overriding the default log level for our backbone internal logs to Information
  • Finally, I surrounded the startup logic with a try catch block, and added some log statements to catch and finally, as this seems to be best practice.

@tnotheis tnotheis added the chore Some routine work like updating dependencies label Oct 18, 2023
@tnotheis tnotheis enabled auto-merge (squash) October 18, 2023 11:55
@tnotheis tnotheis merged commit b5ac7b9 into main Oct 18, 2023
@tnotheis tnotheis deleted the simplify-aspnet-logging branch October 18, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Some routine work like updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants