-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Directory.build.props files and unify namespaces #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hd/backbone into introduce-directory-build-props-file
…erride the properties defined in the file
…hd/backbone into introduce-directory-build-props-file
daniel-almeida-konkconsulting
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
This PR contains 2 refactorings:
Directory.build.props
file. This file helps us define common properties for all .csproj files. For example, I defined theRootNamespace
in this file. Actually, I even added two such files. In the Modules folder, I added another one, which is used to set the namespace toBackbone.Modules.*
(compared toBackbone.*
, which it would be without the file).namespace
andusing
statements.The goal of the second refactoring (next to unification) is that it will be simpler to set log levels for all Backbone components. Before my change we needed something like:
Now we just need:
Also, there are two fixes that must have caused problems in the pipelines for quite some time and that for some reason let the integration tests only for me: