Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/attribute succession #124
Feature/attribute succession #124
Changes from 1 commit
743354b
f3d39f4
52c1933
f71879a
c2590ec
097ce42
cfdabd1
2d9af1f
149decf
af22a47
584eb69
f0483b8
130c0eb
6028bd8
e9ad0a0
0d3a7ca
13daa8f
88d89b2
a687a37
e4f6a69
3195d1d
ffeb0d1
6354520
a8e2f26
dbf5a19
600770b
1aea115
6f5a1f0
fb3599b
ecc5d98
821097e
335ce87
482975e
813ce89
93aabd2
f875d54
6d0344a
c449907
ab7a9e9
fae1b4d
6fde0bb
3fb84c3
fb7664d
e86545b
eeb5b34
5a3018e
975d209
d460bf8
04f282c
96750d0
3033770
c9d5810
9a0158d
32c04fd
34d3d74
076e687
48d6ddb
213dcfb
0c8a407
337552f
57c3698
815b928
cd0e6ed
9b574b8
1e057eb
4ceb26f
b9650b9
7fe20a8
76b966f
e49a0d2
cf16076
bf68641
d116761
670be2f
e1903fb
dee1871
ddfaca7
1bec00a
f5fe9ee
652d8aa
0f41689
c5c48ea
829efaf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the use of any, we might run into some issues with regards to exceptions here. Could you try unknown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean exactly by try? I can replace
any
withunknown
, which the forces me to manually cast the request to some non-unknown
type.What's the problem with
any
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is that you missed a null pointer bug b/c of any.
any
is fine if you don't do anything other than just passing it to the runtime, but can EXPLODE if you handle it like you did it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't get me wrong, we use any everywhere - and at some places there could be bugs because of this.. I think thats all Thomas wants to say :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to try out how the code looks / development behaves, if we use unknown which requires us to cast manually if we want to implement additional logic. I fear, that we need to cast every call then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a major pita to work with
unknown
s, but I do see the merits of it. We can useunknown
s overany
s, but I rather move this discussion/refactoring into a separate PR. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, it is uncomfortable, but we should use unknown where we have custom logic on the request. I'm ok with doing it in another PR. The errors should now be resolved.